+- Moode Forum (https://moodeaudio.org/forum)
+-- Forum: moOde audio player (https://moodeaudio.org/forum/forumdisplay.php?fid=3)
+--- Forum: Support (https://moodeaudio.org/forum/forumdisplay.php?fid=7)
+--- Thread: Local folder playback (/showthread.php?tid=6629)
Pages:
1
2
RE: Local folder playback - schmidtjr - 06-22-2024
(06-22-2024, 01:14 PM)Tim Curtis Wrote: 9.0.2 is latest release
Theres nothing wrong with hard coding specific names. It's done in all software but for sure the name SDCARD is not the ideal folder name when booting from USB drive. Maybe some other name would be better.
Is the bootcode.bin hack needed for certain Pi models?
ETA: Does bootfs and rootfs show up in Folder View?
Hi,
I checked it with 9.0.2 and it's the same. /media lists BOOTFS and rootfs.
In Folder View only rootfs shows up. BOOTFS is filtered out somehow.
The bootcode.bin hack shouldn't be needed for all Pi models. Sorry, no big experience here. I hope I don't need it any longer with the Pi 4. But on the 3 B+ I occasionally had missing boots. LED blinked 7 times, aka "Kernel image not found". I followed this one here to solve it: https://forums.raspberrypi.com/viewtopic.php?t=225812
ah, and it adds lovely "music" files like "USB/rootfs/lib/aarch64-linux-gnu/perl5/5.36/auto/Net/SSLeay/head_https.al"
Regarding the hard coded names. Well, yes. There's nothing wrong with hardcoded names/paths or so. But. When those values are used in different components and each module hardcodes them for itself, then you create an implicit interface between the modules. Hard to maintain, hard to track problems. Here we have some php scripts, shell scripts, and MPD daemon. So at least 3 components that "think" they know where to search for. That's a hidden contract between those components.
But I really don't want to cause trouble here. It was just a finding from me. If one is following the /mnt/SDCARD approach, everything is working fine.
Kind regards,
Martin
RE: Local folder playback - Tim Curtis - 06-22-2024
No trouble at all. Calling out issues with the code is fundamental to Open Source. The challenge in our small project is that dev bandwidth is limited especially for essential but very time consuming refactoring to improve code structure and reduce accumulated bad code. Theres bad code in Moode? Shocking ;-)
If you have a good solution for defining the resource names in a single place that can be accessed by different script languages, MPD etc then feel free to post a Git issue for discussion.