Thumbnail Generator Issue in 9.0.0 - haeckse - 05-22-2024
When starting the "Regenerate Album cover thumbnail cache" button, the status info showed that the scanning process got stuck at a particular album and didn't proceed with other files.
This happened with all files that contained an "Commercial URL:" tag in an ID3 v2.4 taglist
After removing the tag from the files with the eye3D tool, the thumbnail cache has been generated without any issues:
Code: eyeD3 --remove-frame "WCOM" *.mp3
This didn't happen when creating thumbnails for the same MP3 files with the previous moode version 8.3.9
RE: Thumbnail Generator Issue in 9.0.0 - TheOldPresbyope - 05-22-2024
(05-22-2024, 03:28 PM)haeckse Wrote: When starting the "Regenerate Album cover thumbnail cache" button, the status info showed that the scanning process got stuck at a particular album and didn't proceed with other files.
This happened with all files that contained an "Commercial URL:" tag in an ID3 v2.4 taglist
After removing the tag from the files with the eye3D tool, the thumbnail cache has been generated without any issues:
Code: eyeD3 --remove-frame "WCOM" *.mp3
This didn't happen when creating thumbnails for the same MP3 files with the previous moode version 8.3.9
Whoa! Talk about an edge case. What alerted you to this particular metadata item?
If you zip up one of two offending MP3 files, post it on some accessible site, and PM me, @Tim Curtis, and @Nutul one or another of us will take a look.
Keep in mind is that if your files are well-formed, the problem likely lies with one or another library on which moOde code depends. We may end up passing the buck.
Regards,
Kent
RE: Thumbnail Generator Issue in 9.0.0 - haeckse - 05-22-2024
(05-22-2024, 05:04 PM)TheOldPresbyope Wrote: (05-22-2024, 03:28 PM)haeckse Wrote: When starting the "Regenerate Album cover thumbnail cache" button, the status info showed that the scanning process got stuck at a particular album and didn't proceed with other files.
This happened with all files that contained an "Commercial URL:" tag in an ID3 v2.4 taglist
After removing the tag from the files with the eye3D tool, the thumbnail cache has been generated without any issues:
Code: eyeD3 --remove-frame "WCOM" *.mp3
This didn't happen when creating thumbnails for the same MP3 files with the previous moode version 8.3.9
Whoa! Talk about an edge case. What alerted you to this particular metadata item?
If you zip up one of two offending MP3 files, post it on some accessible site, and PM me, @Tim Curtis, and @Nutul one or another of us will take a look.
Keep in mind is that if your files are well-formed, the problem likely lies with one or another library on which moOde code depends. We may end up passing the buck.
Regards,
Kent
@TheOldPresbyope
Well, I'd extracted all the files that made the thumbnail generator get stuck from the library and compared their ID3 tags with those of the files that had been processed without issues. The problematic files differed by the mentioned Commercial-URL tag, pointing to an amazon site that sells the related album.
Over the past 20 years I've used a lot of different tools to rip CDs and pull metadata. Some of them generated an abundance of strange meta tags, like iTunes for example.
But I have cleaned up my library now, so it is not an issue for me anymore. But maybe the root cause can be identified to make the metadata parser more imune to such peculiar tags, so that the thumbnail generator doesn't get stuck.
I'll send you an PM with a link to a file that causes the problem.
This is the ID3 data of the song:
Code: ---------------------------------------------------------------------------------------------------------------
Time: 05:50 MPEG1, Layer III [ 256 kb/s @ 44100 Hz - Stereo ]
---------------------------------------------------------------------------------------------------------------
ID3 v2.4:
title: Jupp
artist: Bap
album: Fuer Usszeschnigge
album artist: Bap
recording date: 1981
track: 5 genre: Deutschrock (id None)
Publisher/label: Emi Int'l
Commercial URL: http://www.amazon.com/gp/redirect.html%3FASIN=B00000I3C7%26tag=softpointer-20%26lcode=xm2%26cID=2025%26ccmID=165953%26location=/o/ASIN/B00000I3C7%253FSubscriptionId=0RXJS26C80QSDEB56CR2
FRONT_COVER Image: [Size: 27034 bytes] [Type: image/jpg]
Description:
Regards,
Andrea
RE: Thumbnail Generator Issue in 9.0.0 - Tim Curtis - 05-22-2024
IIRC this same issue came up several years back and I think the Zend Media MP3 parsing lib is involved. If I get the chance I'll download the test file and see where in the lib the blow up happens.
RE: Thumbnail Generator Issue in 9.0.0 - philrandal - 05-22-2024
How do you identify which file it is choking on?
Moode 9 doesn't seem happy with some .flacs I created with cueripper, but I'd like to track down what's actually happening and on what file it is stopping at.
moodeutl -t doesn't give me any clue.
OK, narrowed it down to this file:
Code: # metaflac --list 01.\ In\ the\ Air\ Tonight.flac
METADATA block #0
type: 0 (STREAMINFO)
is last: false
length: 34
minimum blocksize: 4096 samples
maximum blocksize: 4096 samples
minimum framesize: 14 bytes
maximum framesize: 13360 bytes
sample_rate: 44100 Hz
channels: 2
bits-per-sample: 16
total samples: 14837592
MD5 signature: c60406273101220320886fb1682849d2
METADATA block #1
type: 3 (SEEKTABLE)
is last: false
length: 612
seek points: 34
point 0: sample_number=0, stream_offset=0, frame_samples=4096
point 1: sample_number=438272, stream_offset=636765, frame_samples=4096
point 2: sample_number=880640, stream_offset=1395574, frame_samples=4096
point 3: sample_number=1318912, stream_offset=2081769, frame_samples=4096
point 4: sample_number=1761280, stream_offset=2767227, frame_samples=4096
point 5: sample_number=2203648, stream_offset=3462738, frame_samples=4096
point 6: sample_number=2641920, stream_offset=4335568, frame_samples=4096
point 7: sample_number=3084288, stream_offset=5194626, frame_samples=4096
point 8: sample_number=3526656, stream_offset=6066876, frame_samples=4096
point 9: sample_number=3964928, stream_offset=6845651, frame_samples=4096
point 10: sample_number=4407296, stream_offset=7782872, frame_samples=4096
point 11: sample_number=4849664, stream_offset=8696003, frame_samples=4096
point 12: sample_number=5287936, stream_offset=9623657, frame_samples=4096
point 13: sample_number=5730304, stream_offset=10565535, frame_samples=4096
point 14: sample_number=6172672, stream_offset=11511837, frame_samples=4096
point 15: sample_number=6610944, stream_offset=12521722, frame_samples=4096
point 16: sample_number=7053312, stream_offset=13577535, frame_samples=4096
point 17: sample_number=7495680, stream_offset=14610573, frame_samples=4096
point 18: sample_number=7933952, stream_offset=15587633, frame_samples=4096
point 19: sample_number=8376320, stream_offset=16593871, frame_samples=4096
point 20: sample_number=8818688, stream_offset=17576795, frame_samples=4096
point 21: sample_number=9256960, stream_offset=18534347, frame_samples=4096
point 22: sample_number=9699328, stream_offset=19561288, frame_samples=4096
point 23: sample_number=10141696, stream_offset=20763562, frame_samples=4096
point 24: sample_number=10579968, stream_offset=21905494, frame_samples=4096
point 25: sample_number=11022336, stream_offset=23065898, frame_samples=4096
point 26: sample_number=11464704, stream_offset=24231982, frame_samples=4096
point 27: sample_number=11902976, stream_offset=25394104, frame_samples=4096
point 28: sample_number=12345344, stream_offset=26531501, frame_samples=4096
point 29: sample_number=12787712, stream_offset=27597333, frame_samples=4096
point 30: sample_number=13225984, stream_offset=28592292, frame_samples=4096
point 31: sample_number=13668352, stream_offset=29477989, frame_samples=4096
point 32: sample_number=14110720, stream_offset=30260752, frame_samples=4096
point 33: sample_number=14548992, stream_offset=30808368, frame_samples=4096
METADATA block #2
type: 4 (VORBIS_COMMENT)
is last: false
length: 460
vendor string: reference libFLAC 1.3.1 20141125
comments: 15
comment[0]: CTDBDISCCONFIDENCE=105/107
comment[1]: CTDBTRACKCONFIDENCE=107/107
comment[2]: CDTOC=C+96+6328+A865+ED79+12711+158C3+1B746+1F98D+22668+270C6+29E4B+2F4CD+34A65
comment[3]: TRACKTOTAL=12
comment[4]: TRACKNUMBER=1
comment[5]: TITLE=In the Air Tonight
comment[6]: ALBUM=Face Value
comment[7]: ARTIST=Phil Collins
comment[8]: DISCTOTAL=1
comment[9]: DISCNUMBER=1
comment[10]: DATE=1981
comment[11]: COMMENT=CUERipper v2.1.6 Copyright (C) 2008-13 Grigory Chudov
comment[12]: RELEASE DATE=1981
comment[13]: RELEASECOUNTRY=GB
comment[14]: PUBLISHER=Virgin
METADATA block #3
type: 6 (PICTURE)
is last: false
length: 93
type: 3 (Cover (front))
MIME type: image/gif
description: cover.gif
width: 0
height: 0
depth: 0
colors: 0 (unindexed)
data length: 43
data:
00000000: 47 49 46 38 39 61 01 00 01 00 80 01 00 00 00 00 GIF89a..........
00000010: FF FF FF 21 F9 04 01 00 00 01 00 2C 00 00 00 00 ...!.......,....
00000020: 01 00 01 00 00 02 02 4C 01 00 3B 00 00 00 00 00 .......L..;
METADATA block #4
type: 1 (PADDING)
is last: true
length: 12975
Edit: I suspect it is the embedded cover.gif which is causing the grief. That doesn't seem valid to me.
I'll rip the album again with freac and see what happens.
Problem worked around for the moment.
Cheers,
Phil
RE: Thumbnail Generator Issue in 9.0.0 - Tim Curtis - 05-22-2024
In Library Config click the VIEW STATUS button. It should show the last file that was processed before the generator crashed or if no issues then it shows the completion message and stats.
RE: Thumbnail Generator Issue in 9.0.0 - philrandal - 05-22-2024
(05-22-2024, 08:31 PM)Tim Curtis Wrote: In Library Config click the VIEW STATUS button. It should show the last file that was processed before the generator crashed or if no issues then it shows the completion message and stats.
View status shows:
Scanning folder 84 NAS/Music/Phil Collins/1981 - Face Value
See my edited post for the metadata of the offending file.
If I rename the flacs in that folder it then chokes on some mp3s from some podcasts I'm not too bothered about. Once I cleared those old files out it gets to the end OK.
For whatever reason, Moode 9 seems a bit fussier than Moode 8.3.9 in this respect. It might need a bit of tweaking to handle the failures more gracefully so it skips on error instead of just stopping.
RE: Thumbnail Generator Issue in 9.0.0 - Tim Curtis - 05-22-2024
Prolly not a mere "tweak" to find a solution for something like this, and it's not unique to moode 9 since there have been several reports over the years of various files metadata or corruption causing issues with the thumbnail generator.
I have @haeckse test mp3 file and can repro that issue. When I get the chance I'll see if I can isolate the code thats failing.
RE: Thumbnail Generator Issue in 9.0.0 - radu- - 05-23-2024
I also have issues with tumbnails scanning and I don't know how to check/debug what the problem is. The scanning stops in a folder with mp3 files and I checked other files that were scanned before and have the thumbnail.
Here's one of the files that passed the scanning:
Code: eyeD3 Bagpipes/Bagpipes\ 01\ -\ Inverness\ Gathering\ -\ Australian\ Ladies.mp3
/zet/Muzica/Andreea/Bagpipes/Bagpipes 01 - Inverness Gathering - Australian Ladies.mp3 [ 2.02 MB ]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 02:56 MPEG1, Layer III [ 96 kb/s @ 44100 Hz - Stereo ]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ID3 v2.3:
title: Inverness Gathering/Australian Ladies
artist: Queen Victoria School pipe band
album: Bagpipes & Drums Of Scotland
album artist: World Music
composer: Traditional/W. Fergusson
recording date: 1996
track: 1 genre: Country & Folk (id None)
disc: 1/1
Publisher/label: LaserLight
Unique File ID: [b'http://www.cddb.com/id3/taginfo1.html'] : 3CD3N88S4216928U12839821A5B8E1A49175770175FC6D35CC6P2
UserTextFrame: [Description: GN/ExtData]
GNXDWEcxAagdrSN0iLxx4ypKa/vhUbaPI2d4JAGjPUccplBn2o8WT90xaqyb7TENjzmTM9nORFRjxYZF
PRIV: [Data: 39 bytes]
Owner Id: WM/MediaClassPrimaryID
PRIV: [Data: 41 bytes]
Owner Id: WM/MediaClassSecondaryID
PRIV: [Data: 31 bytes]
Owner Id: WM/WMContentID
PRIV: [Data: 122 bytes]
Owner Id: WM/UniqueFileIdentifier
PRIV: [Data: 34 bytes]
Owner Id: WM/WMCollectionID
PRIV: [Data: 39 bytes]
Owner Id: WM/WMCollectionGroupID
PRIV: [Data: 20 bytes]
Owner Id: WM/Provider
MCDI: [Data: 208 bytes]
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
And here's one from the folder with issues:
Code: Gaelic Storm/Gaelic Storm - After Hours At Mcgann's.mp3[ 3.37 MB ]
-------------------------
Time: 03:41 MPEG1, Layer III [ 128 kb/s @ 44100 Hz - Stereo ]
-------------------------
ID3 v2.3:
title: After Hours At McGann's
artist: Gaelic Storm
album: Special Reserve
album artist: Gaelic Storm
composer: P. Murphy
recording date: 2003
track: 6 genre: Traditional (id None)
disc: 1/1
Publisher/label: OmTown Music
Unique File ID: [b'http://www.cddb.com/id3/taginfo1.html'] : 3CD3N33R88823847V488BA8A6B8EC86BEF6B92DAFA35287E108P2
Comment: [Description: ] [Lang: eng]
UserTextFrame: [Description: GN/ExtData]
GNXDWEcxAedbhMAaAFlbqEHJtnBMOfch4w6EHly+WyThZ0UR/vz4m5wXIL20X5czDmUeZsmrexpNyrvc8WqFNwBSlmlyaIZR5DMz+SI3Yz5ukxKJRR2MuHwA6n0l
b'WXXX' [Description: ]:
I removed the WXXX frame and tried to rescan, but it still stops at the same folder. Then I checked and some of the files had "OTHER IMAGE", so I removed that too, but still no change. How can I see which file breaks the process?
I'm on 9.0.0 on a RPi 4.
RE: Thumbnail Generator Issue in 9.0.0 - radu- - 05-23-2024
@Tim Curtis FYI ^^^
|