+- Moode Forum (https://moodeaudio.org/forum)
+-- Forum: moOde audio player (https://moodeaudio.org/forum/forumdisplay.php?fid=3)
+--- Forum: Support (https://moodeaudio.org/forum/forumdisplay.php?fid=7)
+--- Thread: Track Tab in Audio Info is empty (/showthread.php?tid=7158)
Pages:
1
2
Track Tab in Audio Info is empty - MonoBY - 12-01-2024
Track Tab in Audio Info is empty since v9.1.5, only Playback details are shown
I checked a v9.1.4 Installation, Track and Playback details are shown
RE: Track Tab in Audio Info is empty - Tim Curtis - 12-01-2024
Zip up the album and PM a download link to myself, @TheOldPresbyope and @Nutul. One of us will have a look.
RE: Track Tab in Audio Info is empty - MonoBY - 12-02-2024
That's not the problem. The audio files are tagged correctly and play fine. Just the Track info tab is empty. That's not a essential feature for me, I just wanted to note it.
RE: Track Tab in Audio Info is empty - TheOldPresbyope - 12-02-2024
@MonoBY
The rest of us are dealing with 10s of thousands of tracks tagged using a variety of tools and are seeing no problem with either track or playback info shown in the Audio info modal.
Since you won't provide the information asked for by the maintainer, there's really nothing for us to do here.
Regards,
Kent
ETA - You do have to have selected a track before you'll see any information about a track in the Audio info modal.
RE: Track Tab in Audio Info is empty - the_bertrum - 12-02-2024
I've noticed this too, only on some tracks though. I'll PM a file with one of each in it.
RE: Track Tab in Audio Info is empty - Tim Curtis - 12-02-2024
(12-02-2024, 08:04 AM)the_bertrum Wrote: I've noticed this too, only on some tracks though. I'll PM a file with one of each in it.
The cause of "no track info" is due to an oddity in the length property of Javascript arrays of type Object.
Fixed :-)
https://github.com/moode-player/moode/commit/f6e147411e5de901be89cd01b88077806f928857
RE: Track Tab in Audio Info is empty - TheOldPresbyope - 12-02-2024
An oddity in the length property, of Javascript arrays of type Object, eh? At least I got to listen to a couple of nice tracks while I was scratching my head
Regards,
Kent
RE: Track Tab in Audio Info is empty - Tim Curtis - 12-02-2024
Puzzling to me as well.
Here's the change in the commit.
Code:
- for (i = 0; i < data.length; i++) {
+ for (i = 0; i < Object.keys(data).length; i++) {In the original code "data.length" should always be undefined since the variable "data" is (or should be) of type Object and according to the Javascript spec objects don't have a length property but in fact it was only undefined for the test track that @the_bertrumsent and which replicated the OP issue.
Very odd but the fix seems to work and now the code is correct according to the spec so we'll just move on to next item on the TODO list.
RE: Track Tab in Audio Info is empty - TheOldPresbyope - 12-02-2024
As you say, the fix seems to work (just gulp'ed the repo). Nice.
Regards,
Kent
RE: Track Tab in Audio Info is empty - MonoBY - 12-02-2024
Thank you!