[SOLVED] 9.1.5 & Pi Touch 1: Wrong (max) brightness when waking from screen blanking

[Tim Curtis]

I'll investigate.

[Tim Curtis]

Hi Tim,

while the patch works on my end, the proper solution might even be simpler: I noticed (by accident) that "dtoverlay=rpi-backlight" in the config.txt no longer seems to be necessary for the Pi Touch 1 at all. When I change that to "#dtoverlay=rpi-backlight", the display still works and consistently sets brightness to the value stored in "10-0045/" (and keeps it after screen blank). In this configuration, there is no extra folder "rpi_backlight/" anymore.

So my suggestion would be to remove "dtoverlay=rpi-backlight" and write just to "10-0045/brightness". Or would that cause any other known issues?

By the way, I wouldn't have tried this if there wasn't a little bug in the backup restore procedure: At one point during my tests I used a backup (created in 9.1.5) to restore my settings. Afterwards I noticed that the "rpi_backlight/" folder was gone and the rpi-backlight line was commented out in config.txt (while using the "Pi Touch 1" setting should have left this in).

Side note: During the following tests, I also noticed two (minor) additional issues in the backup restore procedure which are, however, totally independent of the backlight issue:

• Audio output was set to an external USB audio interface (device 0) before restoring. This is also the setting which I can see in the backup file "moodecfg.ini". The restore procedure set the audio output to HDMI (device 1) instead.
  
• The setting "Preference => Library => random album" seems to be missing in the backup file and is therefore not restored.
  

Best regards,
Jens

1. Confirmed that rpi-backlight overlay not needed and that both Touch1 and 2 use 10-0045 for brightness. That greatly simplifies things :-)

2. Added missing "library_onetouch_ralbum" param to backup/restore

3. I can repro "The restore procedure set the audio output to HDMI (device 1) instead." when actual device is a USB audio device. This will take some time to debug.

[Tim Curtis]

Hi Tim,

while the patch works on my end, the proper solution might even be simpler: I noticed (by accident) that "dtoverlay=rpi-backlight" in the config.txt no longer seems to be necessary for the Pi Touch 1 at all. When I change that to "#dtoverlay=rpi-backlight", the display still works and consistently sets brightness to the value stored in "10-0045/" (and keeps it after screen blank). In this configuration, there is no extra folder "rpi_backlight/" anymore.

So my suggestion would be to remove "dtoverlay=rpi-backlight" and write just to "10-0045/brightness". Or would that cause any other known issues?

By the way, I wouldn't have tried this if there wasn't a little bug in the backup restore procedure: At one point during my tests I used a backup (created in 9.1.5) to restore my settings. Afterwards I noticed that the "rpi_backlight/" folder was gone and the rpi-backlight line was commented out in config.txt (while using the "Pi Touch 1" setting should have left this in).

Side note: During the following tests, I also noticed two (minor) additional issues in the backup restore procedure which are, however, totally independent of the backlight issue:

• Audio output was set to an external USB audio interface (device 0) before restoring. This is also the setting which I can see in the backup file "moodecfg.ini". The restore procedure set the audio output to HDMI (device 1) instead.
  
• The setting "Preference => Library => random album" seems to be missing in the backup file and is therefore not restored.
  

Best regards,
Jens

1. Confirmed that rpi-backlight overlay not needed and that both Touch1 and 2 use 10-0045 for brightness. That greatly simplifies things :-)

2. Added missing "library_onetouch_ralbum" param to backup/restore

3. I can repro "The restore procedure set the audio output to HDMI (device 1) instead." when actual device is a USB audio device. This will take some time to debug.

Here's the fix for #3
https://github.com/moode-player/moode/co...2468369de4

Thx for finding those bugs !

[jenzd]

Thanks for fixing!

Best regards,
Jens