12-01-2019, 03:46 PM
(12-01-2019, 03:17 PM)duracell80 Wrote: It would be really helpful to lift the restriction on png images. JPEG's can't have transparency. Usecase would be knock out white logos where if the theme changed the background color of the logo could change too.
We don't need SVG, but not allowing PNG seems a bit crazy.
You would need to weigh the importance to users of the particular feature (transparency) with the effort required to add PNG as an allowable image type for Radio logos. I haven't looked at what might be required. Keep in mind that features compete with one another for limited developer time, and they compete with bug fixes and OS/kernel upgrades.
The relevant code blocks are
https://github.com/moode-player/moode/bl...ayerlib.js
function importLogoImage(files) {
https://github.com/moode-player/moode/bl...worker.php
case 'setlogoimage':
It uses the PHP Image functions
https://www.php.net/manual/en/ref.image.php.
-Tim
