03-02-2020, 12:00 AM
PR was initially rejected cos it was not complete. It did not contain any information on what to test or how I'm supposed to verify it works as you intended. All I got was "Try this in a fresh 6.4.2 to get a feel for the enhancements."
It's a complex PR consisting of > 20 files and as I 'm being asked to review more and more PR's I'm getting a lot pickier about their completeness and whether they make it easy for me to merge and test or whether I have to spend a lot of time figuring out how they are supposed to work.
Nonetheless I reopened the PR yesterday and as time permits I'll try to test it out.
-Tim
It's a complex PR consisting of > 20 files and as I 'm being asked to review more and more PR's I'm getting a lot pickier about their completeness and whether they make it easy for me to merge and test or whether I have to spend a lot of time figuring out how they are supposed to work.
Nonetheless I reopened the PR yesterday and as time permits I'll try to test it out.
-Tim
