06-13-2022, 08:38 PM
@Nutul
Ah, sorry Al.
Apparently if the following three facts are true (or maybe even just one or two) then the ability to report logically should be considered suspect:
Long ago I ripped my entire CD collection to directories containing track-per-file FLACs.
For my test of your code I used CueTools to create a new directory for each of several of the existing CD rips. In each case, CueTools created an album-per-file FLAC and its associated CUE file. In one case, I embedded the album coverart in the album-per-file FLAC and did not include a separate folder.jpg file in the target directory. In the other case, I did not embed the coverart but did include a separate folder.jpg file.
So, everything works as advertised in the case of an album-per-file FLAC with no embedded coverart + CUE file + folder.jpg file. For example, the album coverart image is displayed in the playback panel as each track is played and all the thumbnail displays are correct.
Not so in the case of an album-per-file FLAC with embedded coverart + CUE file and no folder.jpg file. The thumbnail displays are correct but the default cover ("images/default-cover-v6-l.svg") is displayed in place of the album coverart.
Changing the cover search priority has no effect.
It appears coverart.php is being passed a coverurl value based on the CUE file [1] and not the FLAC file. I haven't tried to read the PHP code involved but I'm supposing that if it fails to extract an image then it fails back on the separate image file if it exists, else the default cover image gets used.
To test this hypothesis, I simply added a folder.jpg file to the directory containing the album-per-file FLAC with no embedded coverart. Presto Chango, I now get coverart displayed for this case.
If my supposition is incorrect, then perhaps I somehow screwed up installing your code.
Regards,
Kent
[1] example for a directory which happens to be on a USB thumbdrive: USB/RALLY8GB/Music/Green Day/Warning_/Green Day - Warning_.cue/track0001
Ah, sorry Al.
Apparently if the following three facts are true (or maybe even just one or two) then the ability to report logically should be considered suspect:
- the reporter in question is an old man
- it's well past sundown
- at least one glass of wine has been consumed
Long ago I ripped my entire CD collection to directories containing track-per-file FLACs.
For my test of your code I used CueTools to create a new directory for each of several of the existing CD rips. In each case, CueTools created an album-per-file FLAC and its associated CUE file. In one case, I embedded the album coverart in the album-per-file FLAC and did not include a separate folder.jpg file in the target directory. In the other case, I did not embed the coverart but did include a separate folder.jpg file.
So, everything works as advertised in the case of an album-per-file FLAC with no embedded coverart + CUE file + folder.jpg file. For example, the album coverart image is displayed in the playback panel as each track is played and all the thumbnail displays are correct.
Not so in the case of an album-per-file FLAC with embedded coverart + CUE file and no folder.jpg file. The thumbnail displays are correct but the default cover ("images/default-cover-v6-l.svg") is displayed in place of the album coverart.
Changing the cover search priority has no effect.
It appears coverart.php is being passed a coverurl value based on the CUE file [1] and not the FLAC file. I haven't tried to read the PHP code involved but I'm supposing that if it fails to extract an image then it fails back on the separate image file if it exists, else the default cover image gets used.
To test this hypothesis, I simply added a folder.jpg file to the directory containing the album-per-file FLAC with no embedded coverart. Presto Chango, I now get coverart displayed for this case.
If my supposition is incorrect, then perhaps I somehow screwed up installing your code.
Regards,
Kent
[1] example for a directory which happens to be on a USB thumbdrive: USB/RALLY8GB/Music/Green Day/Warning_/Green Day - Warning_.cue/track0001
