Thank you for your donation!


Cloudsmith graciously provides open-source package management and distribution for our project.


Problem: CUE + Monkey Audio files
#31
(08-12-2024, 10:53 PM)Tim Curtis Wrote: The issue is being caused by a line of old code that was never updated to handle cue files using the super nice CUE support that @Nutul developed.

In fact when using Folder Path as the album key all cue files fail to display tracks because the wrong parent dir is being used to generate the hash for the album key. This causes filteredSongs to be empty and thus the code at line 858 blows up.

Code:
file: "USB/VFAT64/Test_mixed/Jcucurull/APE/Wish you were here/WishYouWereHere.cue/track0001"

# Old code
var md5 = $.md5(obj.file.substring(0,obj.file.lastIndexOf('/')));

# Console demo
$.md5("USB/VFAT64/Test_mixed/Jcucurull/APE/Wish you were here/WishYouWereHere.cue");
e43d5ed42ee8df48e01911713ea701ad

# New code
var md5 = $.md5(getParentDirectory(obj.file));

# Console demo
$.md5("USB/VFAT64/Test_mixed/Jcucurull/APE/Wish you were here");
14507c9ac0b6a8198e06f12292e7235a

I think its that QA guy again ;-)

I'll fix for upcoming 9.0.7

I have a brand new concept for handling the album cover path of the CUEs... it is actually one or two lines of code itself; but it requires reverting some code (probably only the hash-calculator and the parent-folder calculator) to the way it was before...
It could allow many CUEs in the same folder (say, the ARTIST folder) while still providing correct album art to each of them, and hence also one click less while exploring them in FOLDER VIEW.

But I am very busy at the moment, and after all this is more cosmetics than anything else; maybe sometime in the future I will share the concept and we might decide to build upon it.

Enjoy the music (cit.)

P.S.
@Tim Curtis nice catch ;-)
Reply
#32
Sounds good.
Enjoy the Music!
moodeaudio.org | Mastodon Feed | GitHub
Reply
#33
Thanks for looking into it and for the upcoming fix or fixes!
Reply


Forum Jump: