"Mute" UI bug.

[the_bertrum]

Minor little issue on the UI.

1. Mute by tapping the centre of the volume circle on the UI.  Sound is muted.
   
2. Adjust the volume via a rotary encoder. Sound returns, but UI still says "mute".
   
3. Tap "mute" on the UI.  UI shows volume value once more, sound remains unmuted.
   

[Tim Curtis]

Minor little issue on the UI.

1. Mute by tapping the centre of the volume circle on the UI.  Sound is muted.
   
2. Adjust the volume via a rotary encoder. Sound returns, but UI still says "mute".
   
3. Tap "mute" on the UI.  UI shows volume value once more, sound remains unmuted.
   

Right. If volume is changed via external program for example vol.sh, rotary encoder driver or the set_volume REST command the mute state isn't cleared. 

I'll add to the TODO list to investigate.

[Nutul]

Minor little issue on the UI.

1. Mute by tapping the centre of the volume circle on the UI.  Sound is muted.
   
2. Adjust the volume via a rotary encoder. Sound returns, but UI still says "mute".
   
3. Tap "mute" on the UI.  UI shows volume value once more, sound remains unmuted.
   

Right. If volume is changed via external program for example vol.sh, rotary encoder driver or the set_volume REST command the mute state isn't cleared. 

I'll add to the TODO list to investigate.

BTW,

I don't remember if I've already tried this, but if the volume is set to 0dB, I think mute by tapping the volume wheel does not work.
Now, I don't know how the volume works in the fixed 0dB mode, but IMHO it should still allow for mute/unmute.
(Despite I prefer pause to mute, still...)

[Tim Curtis]

I don't think its possible to do mute/unmute for Fixed 0dB because IIRC MPD ignores volume commands when mixer_type is "none" (Fixed 0dB) and the mute function in moode simply sets volume to 0 (muted) or its prior value (unmuted).

[Nutul]

I don't think its possible to do mute/unmute for Fixed 0dB because IIRC MPD ignores volume commands when mixer_type is "none" (Fixed 0dB) and the mute function in moode simply sets volume to 0 (muted) or its prior value (unmuted).

Yep, makes sense...