[SOLVED] moOde 9.0.5 and 9.0.7: Adding radio station to playlist does not work

[kurt1970]

Hi @Tim Curtis ,

Good point! I closed my browser, ran CCleaner and did the test 65x again. All attempts were successful!

[the_bertrum]

So what is missing from our attempts to reproduce this bug? I mean how come kurt1970 could get it almost at will but the rest of us couldn't?

[kurt1970]

So what is missing from our attempts to reproduce this bug?  I mean how come kurt1970 could get it almost at will but the rest of us couldn't?

Some people make a difference... :-) But indeed a very valid question!

@Tim Curtis It is playing since this morning (+6h), and after the browser close, everything works as expected. Great! Tx!

[Tim Curtis]

So what is missing from our attempts to reproduce this bug?  I mean how come kurt1970 could get it almost at will but the rest of us couldn't?

It was not obvious at all but whenever the Queue rendered, for example a new track started playing or station metadata updated it would overwrite a variable that was also reused by the add_to_playlist routine to store the path of the item to be added. 

@kurt1970's issue would occur if the Queue updated after clicking "Add to playlist" and selecting the playlist but before  clicking Add.

[Tim Curtis]

Here's a set of updated files with all the debug logging removed.

Code:

sudo wget -q https://moodeaudio.org/test/lib.min.js -O /var/www/js/lib.min.js
sudo wget -q https://moodeaudio.org/test/main.min.js -O /var/www/js/main.min.js
sudo wget -q https://moodeaudio.org/test/playlist.php -O /var/www/command/playlist.php

[kurt1970]

I'm using moOde on 2 instances playing ~14h a day, every day. Mathematically, this makes the chances you come across an issue bigger than when listening only a couple of hours a day. Coincidence I guess...

[Tim Curtis]

I'm using moOde on 2 instances playing ~14h a day, every day. Mathematically, this makes the chances you come across an issue bigger than when listening only a couple of hours a day. Coincidence I guess...

We got lucky finding this bug. Many thanks for the help :-)

[kurt1970]

Thanks for your fixing it @Tim Curtis :-)!

[the_bertrum]

Well, I can repro when doing mpc command in the console, but I can't get it to trigger just using the UI no matter what I try.

Still, bug squashed so it doesn't matter I suppose.

[kurt1970]

Here's a set of updated files with all the debug logging removed.

Code:

sudo wget -q https://moodeaudio.org/test/lib.min.js -O /var/www/js/lib.min.js
sudo wget -q https://moodeaudio.org/test/main.min.js -O /var/www/js/main.min.js
sudo wget -q https://moodeaudio.org/test/playlist.php -O /var/www/command/playlist.php

Hi @Tim Curtis I replaced the files on both a 9.0.5 and 9.0.6 instance, but something seems to break it, as my playlists are gone after the wgets...