[IDEA] Coverview improvements

[Tim Curtis]

I can make that change.

[romain]

I can make that change.

Well, if this info looks pertinent, yes

Also I thought that if you could display bit depth, sample rate and channels, on "Audio information -> Playback" page, you could also have these displayed on cover view instead of "Unknown"

   

[romain]

Hello,

just for testing I've replaced the 

PHP Code:

$encodedAt = 'Unknown'; 


 at line 703 in music-library.php by the following block of code 

PHP Code:

$sock = getMpdSock();
$mpdStatus = getMpdStatus($sock);
$rate = empty($mpdStatus['audio_sample_rate']) ? '?' : $mpdStatus['audio_sample_rate'];
$encodedAt = 'UPnP stream ' . $mpdStatus['audio_sample_depth'] . '/' . $rate . ' kHz, ' . $mpdStatus['audio_channels']; 


the result below:

   

[Tim Curtis]

Hello,

just for testing I've replaced the 

PHP Code:

$encodedAt = 'Unknown'; 


 at line 703 in music-library.php by the following block of code 

PHP Code:

$sock = getMpdSock();
$mpdStatus = getMpdStatus($sock);
$rate = empty($mpdStatus['audio_sample_rate']) ? '?' : $mpdStatus['audio_sample_rate'];
$encodedAt = 'UPnP stream ' . $mpdStatus['audio_sample_depth'] . '/' . $rate . ' kHz, ' . $mpdStatus['audio_channels']; 


the result below:

Thats the decodedTo format not the encodedAt format
https://mpd.readthedocs.io/en/latest/pro...d-s-status

To see if the encodedAt format is available for an http file reference try mediainfo <URL>

[romain]

Hello,

just for testing I've replaced the 

PHP Code:

$encodedAt = 'Unknown'; 


 at line 703 in music-library.php by the following block of code 

PHP Code:

$sock = getMpdSock();
$mpdStatus = getMpdStatus($sock);
$rate = empty($mpdStatus['audio_sample_rate']) ? '?' : $mpdStatus['audio_sample_rate'];
$encodedAt = 'UPnP stream ' . $mpdStatus['audio_sample_depth'] . '/' . $rate . ' kHz, ' . $mpdStatus['audio_channels']; 


the result below:

Thats the decodedTo format not the encodedAt format
https://mpd.readthedocs.io/en/latest/pro...d-s-status

To see if the encodedAt format is available for an http file reference try mediainfo <URL>

OK, so used this block of code instead

PHP Code:

$result = sysCmd('mediainfo --Inform="Audio;file:///var/www/util/mediainfo.tpl" ' . '"' . $songData['file'] . '"');
$bitDepth = $result[0];
$sampleRate = $result[1];
$channels = $result[2];
$format = $result[3];
$encodedAt = $bitDepth == '?' ?
'UPnP ' . $format . ' stream ' . formatRate($sampleRate) . 'kHz' :
'UPnP ' . $format . ' stream ' . $bitDepth . '/' . formatRate($sampleRate) . ' kHz, ' . $channels . 'ch'; 


 and the resut now (only tested with Tidal and still missing the HD badge)

   

[Tim Curtis]

That could work.

[romain]

That could work.

On the other hand I have no idea how the HD badge is displayed

[romain]

This could look like this until someone finds how to add the HD badge before the song title when necessary.

PHP Code:

$result = sysCmd('mediainfo --Inform="Audio;file:///var/www/util/mediainfo.tpl" ' . '"' . $songData['file'] . '"');
 $bitDepth = $result[0];
$sampleRate = $result[1];
$channels = $result[2];
$format = $result[3];
$encodedAt = 'UPnP ' . $format . ' ' . ($bitDepth == '?' ?
formatRate($sampleRate) . 'kHz' :
$bitDepth . '/' . formatRate($sampleRate) . ' kHz, ' . $channels . 'ch'); 


   

[Tim Curtis]

That could work.

On the other hand I have no idea how the HD badge is displayed

Have a look at the } else { block around line 685

[romain]

That could work.

On the other hand I have no idea how the HD badge is displayed

Have a look at the } else { block around line 685

I can determine if the stream is HD by comparing bit depth and sample rate and tried this 

PHP Code:

$result = sysCmd('mediainfo --Inform="Audio;file:///var/www/util/mediainfo.tpl" ' . '"' . $songData['file'] . '"');
$bitDepth = $result[0];
$sampleRate = $result[1];
$channels = $result[2];
$format = $result[3];
$hiDef = ($bitDepth > ALBUM_BIT_DEPTH_THRESHOLD ||
$sampleRate > ALBUM_SAMPLE_RATE_THRESHOLD) ? 'h' : 's';
$encodedAt = 'UPnP ' . $format . ' ' . $bitDepth . '/' . formatRate($sampleRate) . ' kHz'. ',' . $hiDef . ',' . $channels . 'ch';

/* $encodedAt = 'UPnP ' . $format . ' ' . ($bitDepth == '?' ?
formatRate($sampleRate) . 'kHz' :
$bitDepth . '/' . formatRate($sampleRate) . ' kHz, ' . $channels . 'ch'); */ 


of course I miss something to get the HD badge displayed because as a result I get this