Hi,
Well done guys on getting out v7, there's clearly a lot of work gone into this release.
There is a big problem though, the new album logic is borked and the code is incorrectly handling files that have "Original Artist" tags populated. The logic behind the handling of Album Artist is questionable but the main issue just seems to be the parsing of the artist metadata.
This has resulted in over 1600 albums in my collection wrongly showing as by the artist "Unknown AlbumArtist" (see screenshots).
Many files often come with both "artist" and "original artist" tags populated even if they match (doesn't make a lot of sense but is very common).
The legit intended use of the "original artist" tag is when the track is a cover song so the "artist" tag is the release artist and the "original artist" is who performed the original version.
Looking from line 576 in playerlib.php we have this...
What is happening is that both "artist" and "original artist" tags are being picked up and being handled as an array of multiple artists within an album (even if they're the same string), then the album is handled like a compilation album and thus being slapped with "Unknown AlbumArtist" if there's no "Album Artist" tags. It would be better to tighten up the metadata parsing as to not pick up "original artist" tags or at least omit them when evaluating track/album artists.
There might be other tags causing this I don't know but every affected album I've checked have had the "original artist" tags populated.
This issue then also cascades into affected albums by different artists with the same title being lumped together because they're now handled as the same artist.
These can be separated by changing "Album Key" to "FolderPath" in the advanced library preferences but that then breaks/separates multi-disc albums (correctly tagged with disc number tags) which are often stored in separate subfolders (CD1, CD2 etc.)
It might be because of this that rendering of the tag view is also slower, probably due to the additional amount of in-browser metadata crunching.
Hope that helps.
Vin
Well done guys on getting out v7, there's clearly a lot of work gone into this release.
There is a big problem though, the new album logic is borked and the code is incorrectly handling files that have "Original Artist" tags populated. The logic behind the handling of Album Artist is questionable but the main issue just seems to be the parsing of the artist metadata.
This has resulted in over 1600 albums in my collection wrongly showing as by the artist "Unknown AlbumArtist" (see screenshots).
Many files often come with both "artist" and "original artist" tags populated even if they match (doesn't make a lot of sense but is very common).
The legit intended use of the "original artist" tag is when the track is a cover song so the "artist" tag is the release artist and the "original artist" is who performed the original version.
Looking from line 576 in playerlib.php we have this...
Code:
//@Atair:
// 1. artist can safely be empty, because it is no longed used as substitute for missing album_artist
// 2. album_artist shall never be empty, otherwise the sort routines in scripts-library.js complain,
// because they expect artist as string and not as array in album_artist || artist constructs
// 3. When AlbumArtist is not defined and artist contains a single value, it is assumed that Artist should be a surrogate for ALbumArtist.
// otherwise, when Artist is an array of two and more values or empty, the AlbumArtist is set to 'Unknown' (this is regarded as bad tagging)
'artist' => ($flatData['Artist'] ? $flatData['Artist'] : array()), //@Atair: array is expected in scripts-library.js even when empty
'album_artist' => ($flatData['AlbumArtist'] ? $flatData['AlbumArtist'] : (count($flatData['Artist']) == 1 ? $flatData['Artist'][0] : 'Unknown AlbumArtist')),What is happening is that both "artist" and "original artist" tags are being picked up and being handled as an array of multiple artists within an album (even if they're the same string), then the album is handled like a compilation album and thus being slapped with "Unknown AlbumArtist" if there's no "Album Artist" tags. It would be better to tighten up the metadata parsing as to not pick up "original artist" tags or at least omit them when evaluating track/album artists.
There might be other tags causing this I don't know but every affected album I've checked have had the "original artist" tags populated.
This issue then also cascades into affected albums by different artists with the same title being lumped together because they're now handled as the same artist.
These can be separated by changing "Album Key" to "FolderPath" in the advanced library preferences but that then breaks/separates multi-disc albums (correctly tagged with disc number tags) which are often stored in separate subfolders (CD1, CD2 etc.)
It might be because of this that rendering of the tag view is also slower, probably due to the additional amount of in-browser metadata crunching.
Hope that helps.
Vin
