[SOLVED] Thumbnail Generator Issue in 9.0.0

[Tim Curtis]

Hi Tim,

I think this is as far as I can get with my poor knowledge of PHP.

I have added this code to /var/www/util/thumb-gen.php near line 319;

Code:

workerLog('thumb-gen: getImage(): 5');

                                if (isset($id3v2->apic)) {
                                        //workerLog('thmcache; mp3: id3v2: apic->imageData: length: ' . strlen($id3v2->apic->imageData));
workerLog('thumb-gen: getImage(): 10, imageData = |' . $id3v2->apic->imageData . '|' );
                                        $image = outImage($id3v2->apic->mimeType, $id3v2->apic->imageData);
workerLog('thumb-gen: getImage(): 11, image = |' . $image . '|');
// $image = false;
                                }
                        }

The last lines in moode.log read (when opening with vi to see the unprintable characters):

Code:

20240528 215710 thumb-gen: getImage(): 5
20240528 215710 thumb-gen: getImage(): 10, imageData = |^@^@^@^@|
20240528 215710 thumb-gen: outImage(): image/jpg, 4 bytes
20240528 215710 thumb-gen: getImage(): 11, image = |^@^@^@^@|

After that, the thumbnail generator seems to crash in file_get_contents() at line 168:

Code:

        if (strlen($imgStr) < 512) {
workerLog('thumb-gen: 11, imgStr = ' .$imgStr);
                //workerLog('thumb-gen: Image file: ' . $imgStr);
                $imgStr = file_get_contents($imgStr);
workerLog('thumb-gen: 12');
        }

Moode.log continues:

Code:

20240528 215710 thumb-gen: 10
20240528 215710 thumb-gen: 11, imgStr = ^@^@^@^@

But never prints 'thumb-gen: 12'.

I'm hoping for a solution as I really like MoOde Audio! It might be that the Zend Framework needs to be updated with PHP8?


With best regards,
-Frank

It looks like nulls and any other bad data in the path arg for file_get_contents() causes crash.

Example: Crashing the php shell.

Code:

php > $tim = file_get_contents("\00");
PHP Warning:  Uncaught ValueError: file_get_contents(): Argument #1 ($filename) must not contain any null bytes in php shell code:1
Stack trace:
#0 php shell code(1): file_get_contents()
#1 {main}
 thrown in php shell code on line 1
php >

The fix is to check for a valid file path instead of using the assumption in the "if: statement that if length is < 512 it must be a path and not actual image data.

Code:

if (strlen($imgStr) < 512)

I'll fix for upcoming r901