Official moOde 7.0.0 support thread

[jmarcusg]

Trying to enter SSID manually but MoOde will not take it nor will SCAN find it. Box is outlined in Red and I am prompted to match the requested format. It is <SHIRE>. This has worked in all previous versions.

[Tim Curtis]

Very odd. I can repro but I'm not seeing anything in the code that would be causing this.

Maybe someone else can find the bug.

[TheOldPresbyope]

?

I guess I don’t understand the sequence of steps needed to repo.

[DRONE7]

?

I guess I don’t understand the sequence of steps needed to repo.

using '<' as the first character in the manual SSID box causes it to 'go red' and not accept any further input as legitimate.

[TheOldPresbyope]

?

I guess I don’t understand the sequence of steps needed to repo.

using '<' as the first character in the manual SSID box causes it to 'go red' and not accept any further input as legitimate.

Ah, thanks. I was misreading the OPs sentences. It’s too late here but I’ll have a look in the morning if no one finds the solution before. As always, non-alphanumeric characters, especially ones which have meaning to the shell get my spider sense tingling. Probably a red herring but we’ll see.


Regards,
Kent

[DRONE7]

?

I guess I don’t understand the sequence of steps needed to repo.

using '<' as the first character in the manual SSID box causes it to 'go red' and not accept any further input as legitimate.

Ah, thanks. I was misreading the OPs sentences. It’s too late here but I’ll have a look in the morning if no one finds the solution before. As always, non-alphanumeric characters, especially ones which have meaning to the shell get my spider sense tingling. Probably a red herring but we’ll see.


Regards,
Kent

Yes, my thoughts too... perhaps a change in the underlying Raspberry OS version ? Will go look ...

thought...has the op set the country code...?

[vinnn]

Hi,

Well done guys on getting out v7, there's clearly a lot of work gone into this release.
There is a big problem though, the new album logic is borked and the code is incorrectly handling files that have "Original Artist" tags populated. The logic behind the handling of Album Artist is questionable but the main issue just seems to be the parsing of the artist metadata.
This has resulted in over 1600 albums in my collection wrongly showing as by the artist "Unknown AlbumArtist" (see screenshots).
   
   

Many files often come with both "artist" and "original artist" tags populated even if they match (doesn't make a lot of sense but is very common).
The legit intended use of the "original artist" tag is when the track is a cover song so the "artist" tag is the release artist and the "original artist" is who performed the original version.

Looking from line 576 in playerlib.php we have this...

Code:

//@Atair:
// 1. artist can safely be empty, because it is no longed used as substitute for missing album_artist
// 2. album_artist shall never be empty, otherwise the sort routines in scripts-library.js complain,
//    because they expect artist as string and not as array in album_artist || artist constructs
// 3. When AlbumArtist is not defined and artist contains a single value, it is assumed that Artist should be a surrogate for ALbumArtist.
//    otherwise, when Artist is an array of two and more values or empty, the AlbumArtist is set to 'Unknown' (this is regarded as bad tagging)
'artist' => ($flatData['Artist'] ? $flatData['Artist'] : array()), //@Atair: array is expected in scripts-library.js even when empty
'album_artist' => ($flatData['AlbumArtist'] ? $flatData['AlbumArtist'] : (count($flatData['Artist']) == 1 ? $flatData['Artist'][0] : 'Unknown AlbumArtist')),

What is happening is that both "artist" and "original artist" tags are being picked up and being handled as an array of multiple artists within an album (even if they're the same string), then the album is handled like a compilation album and thus being slapped with "Unknown AlbumArtist" if there's no "Album Artist" tags. It would be better to tighten up the metadata parsing as to not pick up "original artist" tags or at least omit them when evaluating track/album artists.

There might be other tags causing this I don't know but every affected album I've checked have had the "original artist" tags populated.
   

This issue then also cascades into affected albums by different artists with the same title being lumped together because they're now handled as the same artist.
   
These can be separated by changing "Album Key" to "FolderPath" in the advanced library preferences but that then breaks/separates multi-disc albums (correctly tagged with disc number tags) which are often stored in separate subfolders (CD1, CD2 etc.)

It might be because of this that rendering of the tag view is also slower, probably due to the additional amount of in-browser metadata crunching.


Hope that helps.


Vin

[the_bertrum]

Surely the track info below the cover art tells me what track is playing ?

Yes that tells you the name of what's playing but does not show you where in the queue that item is so you can see what it coming next, or how close to the end of the album you are and what not.

If, indeed, the bouncy sticks are for the visually impaired then it would be sensible to have it as an opt-in feature rather than a blanket approach?
Just as most conventional O/S' have a 'High Contrast' option  

Partly an accessibility thing. not specifically for that purpose. The point being that a high contrast scheme tends to minimise the effect of the differently coloured now playing line in the queue and so another visual cue may be helpful. I'm fortunate enough not to be impaired in that way, so I'm no authority on it.

Regarding your comment about it currently not being able to be turned off..surely it is only a line of code ? Just need to know where to comment it out..?

Of course it can be turned off with amending the code, I was referring to there being no option in the config for that. The animation is var/www/images/4band-npicon/audiod.svg and it is set in panels.css I believe. Probably quickest to replace the svg with a non animated version.

[Tim Curtis]

Hi,

Well done guys on getting out v7, there's clearly a lot of work gone into this release.
There is a big problem for me though, the new album logic is borked and the code is incorrectly handling files that have "Original Artist" tags populated. The logic behind the handling of Album Artist is questionable but the main issue just seems to be the parsing of the artist metadata.
This has resulted in over 1600 albums in my collection wrongly showing as by the artist "Unknown AlbumArtist" (see screenshots).



Many files often come with both "artist" and "original artist" tags populated even if they match (doesn't make a lot of sense but is very common).
The legit intended use of the "original artist" tag is when the track is a cover song so the "artist" tag is the release artist and the "original artist" is who performed the original version.

Looking from line 576 in playerlib.php we have this...

Code:

//@Atair:
// 1. artist can safely be empty, because it is no longed used as substitute for missing album_artist
// 2. album_artist shall never be empty, otherwise the sort routines in scripts-library.js complain,
//    because they expect artist as string and not as array in album_artist || artist constructs
// 3. When AlbumArtist is not defined and artist contains a single value, it is assumed that Artist should be a surrogate for ALbumArtist.
//    otherwise, when Artist is an array of two and more values or empty, the AlbumArtist is set to 'Unknown' (this is regarded as bad tagging)
'artist' => ($flatData['Artist'] ? $flatData['Artist'] : array()), //@Atair: array is expected in scripts-library.js even when empty
'album_artist' => ($flatData['AlbumArtist'] ? $flatData['AlbumArtist'] : (count($flatData['Artist']) == 1 ? $flatData['Artist'][0] : 'Unknown AlbumArtist')),

What is happening is that both "artist" and "original artist" tags are being picked up and being handled as an array of multiple artists within an album (even if they're the same string), then the album is handled like a compilation album and thus being slapped with "Unknown AlbumArtist" if there's no "Album Artist" tags. It would be better to tighten up the metadata parsing as to not pick up "original artist" tags or at least omit them when evaluating track/album artists.

There might be other tags causing this I don't know but every affected album I've checked have had the "original artist" tags populated.


This issue then also cascades into affected albums by different artists with the same title being lumped together because they're now handled as the same artist.

These can be separated by changing "Album Key" to "FolderPath" in the advanced library preferences but that then breaks/separates multi-disc albums (correctly tagged with disc number tags) which are often stored in separate subfolders (CD1, CD2 etc.)

It might be because of this that rendering of the tag view is also slower, probably due to the additional amount of in-browser metadata crunching.


Hope that helps.


Vin

Zip up one of the albums and email or PM me a link. I'll add to the TODO list to investigate.

[Rexalex]

Hi,

Post all bug reports and questions concerning moOde 7.0.0 in this thread. Please paste log output, scripts, etc in code boxes for readability.

-Tim

Can not seem to load Ver 7.0  on Allo Usbridge Signature ver 6.7.1 was loading fine seems to hang on a black screen or this screen attached
flashed card a few times no go same card works on Pi3B+
anyone else have this issue ?

Hi,

yes, I have the same problem! I`ve installed ver. 700 on Usbridge only after installintg memory card on Raspberry 3B+, then translocated the card in Usbridge.

Tim Posted a link of a update that works on Usbridge Sig
http://moodeaudio.org/test/moode-r700-iso.zip

Awesome, thanks.